Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Disable iteration in cudf objects and add support for DataFrame initialization with list of Series #5340

Merged
merged 88 commits into from
Jul 15, 2020
Merged

[REVIEW] Disable iteration in cudf objects and add support for DataFrame initialization with list of Series #5340

merged 88 commits into from
Jul 15, 2020

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented May 31, 2020 •
edited
Loading

This PR is dependent on #5326 (hence have some commits from that PR, will go away from diff once #5326 is merged.)

@galipremsagar galipremsagar self-assigned this May 31, 2020
@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress Python Affects Python cuDF API. labels May 31, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@galipremsagar galipremsagar mentioned this pull request Jun 4, 2020
Merged
@galipremsagar galipremsagar added the 0 - Blocked Cannot progress due to external reasons label Jun 13, 2020
@galipremsagar galipremsagar removed the 0 - Blocked Cannot progress due to external reasons label Jun 26, 2020
@galipremsagar galipremsagar mentioned this pull request Jul 14, 2020
Closed
@jakirkham
Copy link
Member

Sorry I missed your ping yesterday @galipremsagar. Is this question still relevant?

@kkraus14
Copy link
Collaborator

Sorry I missed your ping yesterday @galipremsagar. Is this question still relevant?

I believe that is still relevant but we've started moving forward under the assumption that a new dispatched method in dask wouldn't be opposed since it's a place that explicit goes Series --> list

@galipremsagar
Copy link
Contributor Author

galipremsagar commented Jul 14, 2020 •
edited
Loading

Sorry I missed your ping yesterday @galipremsagar. Is this question still relevant?

I believe that is still relevant but we've started moving forward under the assumption that a new dispatched method in dask wouldn't be opposed since it's a place that explicit goes Series --> list

Added an issue for the same: #5689

kkraus14
kkraus14 requested changes Jul 15, 2020
View reviewed changes
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
python/cudf/cudf/core/multiindex.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Show resolved Hide resolved
python/cudf/cudf/tests/test_gpu_arrow_parser.py Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jul 15, 2020
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar merged commit 89740c6 into rapidsai:branch-0.15 Jul 15, 2020
@Iroy30 Iroy30 mentioned this pull request Jul 17, 2020
Merged
@kaatish kaatish mentioned this pull request Jul 17, 2020
Merged
benfred added a commit to benfred/NVTabular that referenced this pull request Jul 17, 2020
@benfred
Fix for working with cudf 0.15
8a8e8f7 
Cudf 0.15 recently disabled iterating over the values of an index, which broke
a number of ops in nvtabular. (change rapidsai/cudf#5340)
Fix by using values_host.
@benfred benfred mentioned this pull request Jul 17, 2020
Merged
benfred added a commit to NVIDIA-Merlin/NVTabular that referenced this pull request Jul 20, 2020
@benfred
Fix for working with cudf 0.15 (#159)
57ee6de 
Cudf 0.15 recently disabled iterating over the values of an index, which broke
a number of ops in nvtabular. (change rapidsai/cudf#5340)
Fix by using values_host.
mikemckiernan pushed a commit to NVIDIA-Merlin/NVTabular that referenced this pull request Nov 24, 2022
@benfred
Fix for working with cudf 0.15 (#159)
d767bad 
Cudf 0.15 recently disabled iterating over the values of an index, which broke
a number of ops in nvtabular. (change rapidsai/cudf#5340)
Fix by using values_host.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu left review comments

@shwina shwina shwina left review comments

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
6 participants
@galipremsagar @GPUtester @jakirkham @kkraus14 @shwina @rgsl888prabhu