Vendor libnvcomp in libcudf #19743
Vendor libnvcomp in libcudf #19743
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
bdice
added
improvement
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
python/libcudf/CMakeLists.txt
Outdated
| install( | ||
| FILES ${nvcomp_lib_path} | ||
| DESTINATION ${SKBUILD_PLATLIB_DIR}/libcudf/lib64/ | ||
| RENAME libnvcomp.so.5 |
There was a problem hiding this comment.
@KyleFromNVIDIA Is there a way to know the SOVERSION and use that programmatically rather than hardcoding 5 here? Or maybe we need a regex to extract the first digit after ".so" in the filepath...?
There was a problem hiding this comment.
Cursor found a solution I like in d5c47cc. See what you think.
There was a problem hiding this comment.
Why not just copy over the WheelHelpers file that you deleted in kvikio? This is precisely the use case we wrote it for.
There was a problem hiding this comment.
I looked over this with @KyleFromNVIDIA just now. WheelHelpers.cmake installed too many things -- it got both libnvcomp.so.5 and libnvcomp.so.5.0.0.6. We do not have enough binary size available in libcudf's wheels to ship both. We can only afford to ship the soversion'd file.
Description
Now that kvikio no longer uses nvcomp, we need to vendor libnvcomp in the libcudf wheels so that nvcomp can be fully removed as a dependency of kvikio.
Merge this just before rapidsai/kvikio#805.
Checklist