Skip to content

Add strings zfill overload to accept widths column #19090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 12, 2025
Merged

Add strings zfill overload to accept widths column #19090

merged 6 commits into from
Jun 12, 2025

Conversation

@davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Jun 4, 2025

Description

Adds new cudf::strings::zfill_by_widths API to accept the minimum width parameter as a column of integers.

Reference #19035

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Jun 4, 2025
@davidwendt davidwendt requested a review from a team as a code owner June 4, 2025 18:45
@davidwendt davidwendt added the 3 - Ready for Review Ready for review by team label Jun 4, 2025
@davidwendt davidwendt requested a review from a team as a code owner June 4, 2025 18:45
@davidwendt davidwendt added the libcudf Affects libcudf (C++/CUDA) code. label Jun 4, 2025
@davidwendt davidwendt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 4, 2025
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Jun 4, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Jun 4, 2025
brandon-b-miller
brandon-b-miller approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python/Cython LGTM. Thanks @davidwendt !

vuule
vuule reviewed Jun 4, 2025
View reviewed changes
@davidwendt davidwendt requested a review from vuule June 9, 2025 21:58
@vyasr vyasr mentioned this pull request Jun 12, 2025
Merged
@davidwendt
Copy link
Contributor Author

davidwendt commented Jun 12, 2025

/merge

@rapids-bot rapids-bot bot merged commit 24d5a90 into rapidsai:branch-25.08 Jun 12, 2025
94 checks passed
@davidwendt davidwendt deleted the zfill-width-column branch June 12, 2025 12:35
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@vuule vuule vuule approved these changes

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger TomAugspurger is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu kingcrimsontianyu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.

Projects

cuDF Python
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidwendt @mhaseeb123 @vuule @brandon-b-miller