Deprecate cudf.Scalar #18394
Open
Deprecate cudf.Scalar #18394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
Matt711
reviewed
Apr 2, 2025
| @@ -471,6 +458,9 @@ class Scalar(BinaryOperand, metaclass=CachedScalarInstanceMeta): | |||
| _VALID_BINARY_OPERATIONS = BinaryOperand._SUPPORTED_BINARY_OPERATIONS | |||
|
|
|||
| def __init__(self, value, dtype=None): | |||
| warnings.warn( | |||
There was a problem hiding this comment.
Some tests are failing because of this warning. I guess there are still some places where we use cudf.Scalar?
There was a problem hiding this comment.
Yup, thanks. I haven't merged in #18331 yet from branch 25.06 which should be the last internal usage of cudf.Scalar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependent on #18331
xref #17843
Removed tests that constructed a
cudf.Scalar. Code paths that check for acudf.Scalarremain.Added a test for this deprecation in
test_scalar.pyChecklist