Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Series(dtype=object) raise in mode.pandas_compat with non string data #17804

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Make Series(dtype=object) raise in mode.pandas_compat with non string data #17804

merged 4 commits into from
Jan 24, 2025

Conversation

mroeschke
Copy link
Contributor

Description

closes #17752

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Jan 24, 2025
@mroeschke mroeschke self-assigned this Jan 24, 2025
@mroeschke mroeschke requested a review from a team as a code owner January 24, 2025 00:33
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 3d5cafc into rapidsai:branch-25.02 Jan 24, 2025
105 of 107 checks passed
@mroeschke mroeschke deleted the bug/pandas_compat/object branch January 25, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

@galipremsagar galipremsagar

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] error not being raised when dtype=object and the real data is not str dtype
2 participants
@mroeschke @galipremsagar