Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce libcudf memcheck tests output #17791

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Jan 23, 2025

Uses the GTEST_BRIEF=1 environment variable to reduce the output of the memcheck script.
This should help find errors more quickly in the nightly memcheck build output.

Example output where 1 test fails in the entire STRINGS_TEST

$ export GTEST_BRIEF=1
$ gtests/STRINGS_TEST 
/cudf/cpp/tests/utilities/column_utilities.cu:566: Failure
Failed
first difference: lhs[12] = 50089, rhs[12] = 500890
Google Test trace:
/cudf/cpp/tests/strings/attrs_tests.cpp:45:  <--  line of failure

[  FAILED  ] StringsAttributesTest.CodePoints (13 ms)
[==========] 488 tests from 53 test suites ran. (697 ms total)
[  PASSED  ] 487 tests.

It reports only on failing tests.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 23, 2025
@davidwendt davidwendt self-assigned this Jan 23, 2025
@davidwendt davidwendt requested a review from a team as a code owner January 23, 2025 14:56
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Jan 23, 2025
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b65ad08 into rapidsai:branch-25.02 Jan 23, 2025
120 checks passed
@davidwendt davidwendt deleted the reduce-memcheck-output branch January 23, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants