Add shellcheck to pre-commit and fix warnings #17778
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
added
improvement
gforsyth
commented
Jan 22, 2025
Comment on lines
+29
to
+30
| for nb in "$@"; do | ||
| NBFILENAME=$nb |
There was a problem hiding this comment.
Note that previously this was only running over whichever notebook was passed as the first argument to nbtest.sh,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shellcheckis a fast, static analysis tool for shell scripts. It's good atflagging up unused variables, unintentional glob expansions, and other potential
execution and security headaches that arise from the wonders of
bash(andother shlangs).
This PR adds a
pre-commithook to runshellcheckon all of thesh-langfiles in the
ci/directory, and the changes requested byshellcheckto makethe existing files pass the check.
xref: rapidsai/build-planning#135
Checklist