allow deselecting nvcomp wheels #17774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
jameslamb
changed the title
bdice
reviewed
Jan 21, 2025
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
approved these changes
Jan 22, 2025
|
I think we needed to merge the upstream to get #17777, so I did that. I’ll trigger a merge. |
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/kvikio
that referenced
this pull request
Jan 22, 2025
Follow-up to #478 Adds a matrix filter `use_cuda_wheels` in the `dependencies.yaml` list used for `libkvikio`'s `nvcomp` dependency. Some types of builds (like RAPIDS devcontainers) prefer to use the system-installed nvCOMP to one provided by wheels. This ensures that preference is respected, because those builds pass matrix selector `use_cuda_wheels=false` through `rapids-dependency-file-generator` (rapidsai/devcontainers#382). ## Notes for Reviewers Similar changes in cuDF: rapidsai/cudf#17774 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #16946
Adds a matrix filter
use_cuda_wheelsin thedependencies.yamllist used forlibcudf'snvcompdependency. Some types of builds (like RAPIDS devcontainers) prefer to use the system-installed nvCOMP to one provided by wheels.This ensures that preference is respected, because those builds pass matrix selector
use_cuda_wheels=falsethroughrapids-dependency-file-generator(rapidsai/devcontainers#382).Notes for Reviewers
How I tested this
Saw that
nvidia-nvcomp-cu12made it into the environment in pip devcontainers builds in previous PRs:(logs from recent PR build in this repo)
It's not there as of this PR 😁
(build link)
Checklist