Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate dataframe protocol #17736

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Deprecate dataframe protocol #17736

merged 2 commits into from
Jan 15, 2025

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jan 14, 2025

Description

Resolves #17403

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 14, 2025
@vyasr vyasr self-assigned this Jan 14, 2025
@vyasr vyasr requested a review from a team as a code owner January 14, 2025 18:08
@vyasr vyasr requested review from wence- and Matt711 January 14, 2025 18:08
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 14, 2025
@vyasr vyasr requested a review from Matt711 January 15, 2025 00:52
Matt711
Matt711 approved these changes Jan 15, 2025
View reviewed changes
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Jan 15, 2025

/merge

@rapids-bot rapids-bot bot merged commit 2b6cf07 into rapidsai:branch-25.02 Jan 15, 2025
106 checks passed
@vyasr vyasr deleted the deprecate/dataframe_protocol branch January 15, 2025 18:21
@jakirkham jakirkham mentioned this pull request Jan 16, 2025
Merged
@bdice bdice mentioned this pull request Jan 16, 2025
Merged
raydouglass pushed a commit to rapidsai/cuml that referenced this pull request Jan 21, 2025
@bdice @dantegd
Ignore cudf's __dataframe__ deprecation. (#6229)
01e19bb 
Currently CI is failing due to
rapidsai/cudf#17736.

The `__dataframe__` protocol appears to be used internally by
scikit-learn:
https://github.com/scikit-learn/scikit-learn/blob/311bf6badd74bb69081eb90e2643f15706d3473c/sklearn/utils/validation.py#L389

Errors look like:
```
FAILED test_metrics.py::test_sklearn_search - FutureWarning: Using `__dataframe__` is deprecated
```

This PR ignores the `FutureWarning` to allow CI to pass.

---------

Co-authored-by: Dante Gama Dessavre <danteg@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Deprecate and remove data interchange protocol
3 participants
@vyasr @galipremsagar @Matt711