Add seed parameter to hash_character_ngrams #17643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
davidwendt
added
3 - Ready for Review
|
/ok to test |
|
/ok to test |
davidwendt
added
breaking
ttnghia
approved these changes
Jan 9, 2025
bdice
approved these changes
Jan 10, 2025
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
The seed parameter was added to `nvtext::hash_character_ngrams` in #17643 but was not added to the Python interface. This PR adds the parameter to the pylibcudf function and Python interface methods. Authors: - David Wendt (https://github.com/davidwendt) - Matthew Murray (https://github.com/Matt711) Approvers: - Matthew Roeschke (https://github.com/mroeschke) - Matthew Murray (https://github.com/Matt711) URL: #17994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a seed parameter to the
nvtext::hash_character_ngramsAPI.Makes this more useful in conjunction with other nvtext APIs.
Checklist