Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix groupby(as_index=False).size not reseting index #17499

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fix groupby(as_index=False).size not reseting index #17499

merged 3 commits into from
Dec 4, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #17478

Also fixes a bug where the Series.name attribute wasn't preserved with size

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Dec 3, 2024
@mroeschke mroeschke self-assigned this Dec 3, 2024
@mroeschke mroeschke requested a review from a team as a code owner December 3, 2024 22:35
@mroeschke mroeschke requested review from vyasr and bdice December 3, 2024 22:35
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 47e49d0 into rapidsai:branch-25.02 Dec 4, 2024
105 checks passed
@mroeschke mroeschke deleted the bug/gb/size/as_index branch December 4, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

@galipremsagar galipremsagar

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cuDF and Pandas return different results when passing as_index=False in a groupby-size operation
4 participants
@mroeschke @galipremsagar @bdice @Matt711