make conda installs in CI stricter (part 2) #17042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
This was referenced Oct 10, 2024
jameslamb
changed the title
KyleFromNVIDIA
approved these changes
Oct 11, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #17013
Changes relative to that PR:
rapids-version({major}.{minor}.{patch}) instead ofrapids-version-major-minor({major}.{minor}), to get a bit more protection in the presence of hotfix releasesI made some mistakes in #17013 (comment). Missed that this project's Doxygen setup is expecting to find
RAPIDS_VERSIONandRAPIDS_VERSION_MAJOR_MINORdefined in the environment.cudf/cpp/doxygen/Doxyfile
Line 41 in 7173b52
cudf/cpp/doxygen/Doxyfile
Line 2229 in 7173b52
Checklist