Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin polars for 24.10 and update polars test suite xfail list #16886

Merged

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Sep 24, 2024

Description

For releases, since the polars release cadence is quite a lot faster than rapids, we propose to hard-pin to a known good version. In this case, 1.8.x.

At the same time, remove pin in CI scripts and update list of xfailing tests in the polars test suite.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested review from a team as code owners September 24, 2024 11:49
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Sep 24, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 24, 2024
There's now a distinction in the polars IR between pl.lit([[...]]) and
pl.Series([[...]]). We only see the latter, which is translated to
LiteralColumn, so add in a new groupby aggregation expression.
@galipremsagar
Copy link
Contributor

/merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 25, 2024
@rapids-bot rapids-bot bot merged commit 4160423 into rapidsai:branch-24.10 Sep 25, 2024
101 checks passed
@wence- wence- deleted the wence/fix/cudf-polars-test-pin branch September 25, 2024 14:43
Matt711 pushed a commit to mroeschke/cudf that referenced this pull request Sep 25, 2024
…i#16886)

For releases, since the polars release cadence is quite a lot faster than rapids, we propose to hard-pin to a known good version. In this case, 1.8.x.

At the same time, remove pin in CI scripts and update list of xfailing tests in the polars test suite.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: rapidsai#16886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants