-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin polars for 24.10 and update polars test suite xfail list #16886
Merged
rapids-bot
merged 8 commits into
rapidsai:branch-24.10
from
wence-:wence/fix/cudf-polars-test-pin
Sep 25, 2024
Merged
Pin polars for 24.10 and update polars test suite xfail list #16886
rapids-bot
merged 8 commits into
rapidsai:branch-24.10
from
wence-:wence/fix/cudf-polars-test-pin
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to expose some information from the rust IR, due to some refactoring on their side.
github-actions
bot
added
Python
Affects Python cuDF API.
cudf.polars
Issues specific to cudf.polars
labels
Sep 24, 2024
wence-
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Sep 24, 2024
jameslamb
approved these changes
Sep 24, 2024
There's now a distinction in the polars IR between pl.lit([[...]]) and pl.Series([[...]]). We only see the latter, which is translated to LiteralColumn, so add in a new groupby aggregation expression.
galipremsagar
approved these changes
Sep 25, 2024
/merge |
galipremsagar
added
the
5 - Ready to Merge
Testing and reviews complete, ready to merge
label
Sep 25, 2024
Matt711
pushed a commit
to mroeschke/cudf
that referenced
this pull request
Sep 25, 2024
…i#16886) For releases, since the polars release cadence is quite a lot faster than rapids, we propose to hard-pin to a known good version. In this case, 1.8.x. At the same time, remove pin in CI scripts and update list of xfailing tests in the polars test suite. Authors: - Lawrence Mitchell (https://github.com/wence-) Approvers: - James Lamb (https://github.com/jameslamb) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: rapidsai#16886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
cudf.polars
Issues specific to cudf.polars
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For releases, since the polars release cadence is quite a lot faster than rapids, we propose to hard-pin to a known good version. In this case, 1.8.x.
At the same time, remove pin in CI scripts and update list of xfailing tests in the polars test suite.
Checklist