Annotate ColumnAccessor._data
labels as Hashable
#16623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivating change here is that since we store a dictionary of columns in
ColumnAccessor
, the labels should becollections.abc.Hashable
and therefore we can type methods that select by key with this annotation.This led to a mypy-typing-validation cascade that made me type the output of
def as_column(...) -> ColumnBase
which also lead to typing validation in several other files.Namely there no logic changes here.
Checklist