Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CUDA whole compilation ODR violations #16603

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

CUDA whole compilation mode requires that all kernels are only launched from TUs that compile them. Previously libcudf would compile a subset of kernels in separate TUs from where they are launched.
To keep compile times ( and library size ) as low as possible I have introduced a single C++ function call between the original call site and the kernel launch. In testing this neglibile differences on compile time and binary size.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Non-breaking change labels Aug 19, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 19, 2024
@robertmaynard robertmaynard marked this pull request as ready for review August 20, 2024 15:17
@robertmaynard robertmaynard requested a review from a team as a code owner August 20, 2024 15:17
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this is basically just adding an extra level of indirection so that the kernels are only compiled once and hidden beneath a single C++ launch function that can be called in different TUs? If so, LGTM.

@robertmaynard
Copy link
Contributor Author

IIUC this is basically just adding an extra level of indirection so that the kernels are only compiled once and hidden beneath a single C++ launch function that can be called in different TUs? If so, LGTM.

That is correct

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 96f2cc5 into rapidsai:branch-24.10 Aug 26, 2024
98 checks passed
@robertmaynard robertmaynard deleted the bug/remove_cuda_odr_violations branch August 26, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants