MAINT: Adapt to numpy hiding flagsobject away #16593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy hid the `flagsobj` type into the `_core` module. It may make sense for NumPy to put it somewhere less "private", but I think it is fine to consider this semi-private. However, we need to avoid the deprecation warning (oddly, found in the cuml test suite, and not here).
github-actions
bot
added
Python
seberg
added
bug
galipremsagar
approved these changes
Aug 19, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy hid the
flagsobjtype into the_coremodule. It may make sense for NumPy to put it somewhere less "private", but I think it is fine to consider this semi-private.However, we need to avoid the deprecation warning (oddly, found in the cuml test suite, and not here).
Description
Checklist