Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework strings::slice benchmark to use nvbench #16563

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Rework strings::slice benchmark to use nvbench #16563

merged 1 commit into from
Aug 27, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Moves google-benchmark for cudf::strings::slice_strings to nvbench.
This is to help measure performance improvements in follow on work for strings-slice.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 14, 2024
@davidwendt davidwendt self-assigned this Aug 14, 2024
@github-actions github-actions bot added the CMake CMake build issue label Aug 14, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 19, 2024
@davidwendt davidwendt marked this pull request as ready for review August 19, 2024 12:59
@davidwendt davidwendt requested a review from a team as a code owner August 19, 2024 12:59
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d1412e0 into rapidsai:branch-24.10 Aug 27, 2024
72 checks passed
@davidwendt davidwendt deleted the slice-nvbench branch August 27, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @ttnghia