Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded output size parameter from internal count_matches utility #16531

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Removes output_size parameter from cudf::strings::detail::count_matches utility since the output size should equal the input size from the first parameter. This also removes an unnecessary assert() call. The parameter became unnecessary as part of the large strings work.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 12, 2024
@davidwendt davidwendt self-assigned this Aug 12, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 13, 2024
@davidwendt davidwendt marked this pull request as ready for review August 13, 2024 14:05
@davidwendt davidwendt requested a review from a team as a code owner August 13, 2024 14:05
@davidwendt davidwendt requested review from shrshi and ttnghia August 13, 2024 14:05
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c20d6b3 into rapidsai:branch-24.10 Aug 14, 2024
92 checks passed
@davidwendt davidwendt deleted the remove-count-matches-output-size branch August 14, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants