Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support named aggregations in df.groupby().agg() #16528

Merged
merged 16 commits into from
Aug 15, 2024
Merged

[FEA] Support named aggregations in df.groupby().agg() #16528

merged 16 commits into from
Aug 15, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Aug 10, 2024

Description

Closes #15967

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request Python Affects Python cuDF API. labels Aug 10, 2024
@Matt711 Matt711 self-assigned this Aug 10, 2024
@Matt711 Matt711 requested a review from a team as a code owner August 10, 2024 01:26
@Matt711 Matt711 requested review from mroeschke and lithomas1 August 10, 2024 01:26
@Matt711 Matt711 added the non-breaking Non-breaking change label Aug 10, 2024
@Matt711 Matt711 changed the title [FEA] Support named aggregations in df.groupby().agg() [FEA] Support named aggregations in df.groupby().agg() Aug 10, 2024
@Matt711 Matt711 mentioned this pull request Aug 10, 2024
Closed
3 tasks
@Matt711 Matt711 requested a review from a team as a code owner August 12, 2024 11:52
@Matt711 Matt711 added the 3 - Ready for Review Ready for review by team label Aug 13, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 13, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Matt711
Copy link
Contributor Author

Matt711 commented Aug 13, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Aug 14, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Aug 14, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Aug 14, 2024

/ok to test

mroeschke
mroeschke approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM

@Matt711
Copy link
Contributor Author

Matt711 commented Aug 15, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0253e97 into rapidsai:branch-24.10 Aug 15, 2024
71 checks passed
This was referenced Sep 4, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzamora rjzamora rjzamora left review comments

@mroeschke mroeschke mroeschke approved these changes

@lithomas1 lithomas1 Awaiting requested review from lithomas1 lithomas1 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support named aggregations in df.groupby().agg()
3 participants
@Matt711 @mroeschke @rjzamora