Fix date_range(start, end, freq)
when end-start is divisible by freq
#16516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
xref #16507
date_range
generates its dates viarange
, and the end of this range was calculated viamath.ceil((end - start) / freq)
. If(end - start) / freq
did not produce a remainder,math.ceil
would not correctly increment this value by1
to capture the last date.Instead, this PR uses
math.floor((end - start) / freq) + 1
to always ensure the last date is capturedChecklist