Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stream param in transform APIs #16452

Merged
merged 23 commits into from
Aug 8, 2024
Merged

Expose stream param in transform APIs #16452

merged 23 commits into from
Aug 8, 2024

Conversation

JayjeetAtGithub
Copy link
Contributor

@JayjeetAtGithub JayjeetAtGithub commented Jul 31, 2024 •
edited
Loading

Description

Exposes the stream param in transform APIs

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 31, 2024
@JayjeetAtGithub JayjeetAtGithub added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Jul 31, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 31, 2024
@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review July 31, 2024 21:18
@JayjeetAtGithub JayjeetAtGithub requested a review from a team as a code owner July 31, 2024 21:18
@github-actions github-actions bot added the CMake CMake build issue label Jul 31, 2024
bdice
bdice approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems fine to me!

@davidwendt
Copy link
Contributor

Is there some special need for this specific API?
Just wondering since there are only 2 other APIs in transform.hpp
Maybe you can include those in this PR? If the changes are too big, then I understand breaking them up into separate PRs.

@JayjeetAtGithub JayjeetAtGithub changed the title Expose stream param in compute_column Expose stream param in transform APIs Aug 1, 2024
karthikeyann
karthikeyann approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cpp/src/interop/to_arrow_host.cu Show resolved Hide resolved
davidwendt
davidwendt previously requested changes Aug 5, 2024
View reviewed changes
cpp/tests/streams/transform_test.cu Outdated Show resolved Hide resolved
@JayjeetAtGithub
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c146eed into rapidsai:branch-24.10 Aug 8, 2024
79 checks passed
@lamarrr lamarrr mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@davidwendt davidwendt davidwendt left review comments

@srinivasyadav18 srinivasyadav18 Awaiting requested review from srinivasyadav18 srinivasyadav18 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JayjeetAtGithub @davidwendt @bdice @karthikeyann