Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve order in left join for cudf-polars #16268

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Preserve order in left join for cudf-polars #16268

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f3840b
Expose type_to_id in cython and use in pylibcudf for size_type
wence- Jul 12, 2024
362f579
Don't hardcode int32 for size_type_dtype
wence- Jul 12, 2024
c4f2501
Simplify column from gather map helper
wence- Jul 12, 2024
b8976c1
Use new size_type singleton
wence- Jul 12, 2024
c377432
Match ordering requirements of polars for left join
wence- Jul 1, 2024
966c71d
Assert row order is maintained in left join
wence- Jul 12, 2024
652276b
Remove unnecessary cimports
wence- Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use new size_type singleton
  • Loading branch information
@wence-
wence- committed Jul 19, 2024
commit b8976c11394727618e597a2ca78636164a25a196
3 changes: 1 addition & 2 deletions python/cudf_polars/cudf_polars/containers/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,7 @@ def nan_count(self) -> int:
plc.reduce.reduce(
plc.unary.is_nan(self.obj),
plc.aggregation.sum(),
# TODO: pylibcudf needs to have a SizeType DataType singleton
plc.DataType(plc.TypeId.INT32),
plc.types.SIZE_TYPE,
)
).as_py()
return 0
Expand Down