Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupby_max multi-threaded benchmark #16154

Merged
merged 12 commits into from
Jul 10, 2024
Merged

Add groupby_max multi-threaded benchmark #16154

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4bdb7d9
Add groupby_max multi-threaded benchmark
srinivasyadav18 Jul 1, 2024
3e6cfb3
Add multistream bench
srinivasyadav18 Jul 3, 2024
37f493c
drop multithreaded_cardinality bench
srinivasyadav18 Jul 3, 2024
4136871
Add more types for benchmarking
srinivasyadav18 Jul 3, 2024
e37f707
minor cleanup
srinivasyadav18 Jul 3, 2024
ca049ff
further cleanup
srinivasyadav18 Jul 3, 2024
32181eb
Add num_aggregations axis and remove multistream benchmark
srinivasyadav18 Jul 5, 2024
c32ccb6
fix minor nits
srinivasyadav18 Jul 8, 2024
5808e2b
add threads submit loop to timer
srinivasyadav18 Jul 9, 2024
bdc40df
Merge branch 'branch-24.08' into groupby_max_multithread_nvbench
srinivasyadav18 Jul 9, 2024
8e08aa4
Reduce default number of aggregations
srinivasyadav18 Jul 10, 2024
d5fc3d4
Merge branch 'groupby_max_multithread_nvbench' of https://github.com/…
srinivasyadav18 Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor cleanup
  • Loading branch information
@srinivasyadav18
srinivasyadav18 committed Jul 3, 2024
commit e37f7071fbe35e0e31162bf607f7aa3282f4a777
9 changes: 7 additions & 2 deletions cpp/benchmarks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,13 @@ ConfigureBench(
)

ConfigureNVBench(
GROUPBY_NVBENCH groupby/group_max.cpp groupby/group_max_multistream.cpp groupby/group_max_multithreaded.cpp
groupby/group_nunique.cpp groupby/group_rank.cpp groupby/group_struct_keys.cpp
GROUPBY_NVBENCH
groupby/group_max.cpp
groupby/group_max_multistream.cpp
groupby/group_max_multithreaded.cpp
groupby/group_nunique.cpp
groupby/group_rank.cpp
groupby/group_struct_keys.cpp
)

# ##################################################################################################
Expand Down
10 changes: 0 additions & 10 deletions cpp/benchmarks/groupby/group_max_multithreaded.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,6 @@ void bench_groupby_max_multithreaded(nvbench::state& state, nvbench::type_list<T
groupby_max_multithreaded_helper<Type>(state, num_rows, cardinality, null_probability);
}

template <typename Type>
void bench_groupby_max_multithreaded_cardinality(nvbench::state& state, nvbench::type_list<Type>)
{
auto constexpr num_rows = 20'000'000;
auto constexpr null_probability = 0.;
auto const cardinality = static_cast<cudf::size_type>(state.get_int64("cardinality"));

groupby_max_multithreaded_helper<Type>(state, num_rows, cardinality, null_probability);
}

NVBENCH_BENCH_TYPES(bench_groupby_max_multithreaded,
NVBENCH_TYPE_AXES(nvbench::type_list<int32_t, int64_t, float, double>))
.set_name("groupby_max_multithreaded")
Expand Down
Loading