Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer copying in Column.astype(copy=True) #16095

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Avoids:

  1. Copying self when the astype would already produce a new column with its own data
  2. Copying self when the astype would raise an Exception

Also cleans up some as_categorical_column logic.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 26, 2024
@mroeschke mroeschke requested a review from a team as a code owner June 26, 2024 02:14
@mroeschke mroeschke requested review from bdice and Matt711 June 26, 2024 02:14
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit cf88f8e into rapidsai:branch-24.08 Jul 9, 2024
79 checks passed
@mroeschke mroeschke deleted the perf/copy/col/astype branch July 9, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants