Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide visibility of non public symbols #15982

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
4f90a11
Remove usage of null related detail functions
robertmaynard Jul 10, 2024
14fdb58
Explicitly export the pre-compiled aggregation templates
robertmaynard Jun 10, 2024
6324f11
Remove unneeded default parameters
robertmaynard Jun 10, 2024
4f3bc20
All cpp/ sources include the respective header
robertmaynard Jun 11, 2024
5126cae
Ensure minimal set of cpp/ functions used by tests are marked public
robertmaynard Jun 11, 2024
19ca57a
nvtext public API is marked as public symbols
robertmaynard Jun 11, 2024
9f0ffd0
cudftestutil public API is marked as public symbols
robertmaynard Jun 11, 2024
e5f59d5
cudf public API is marked as public symbols
robertmaynard Jun 11, 2024
0cb912a
Ensure installed cudf detail API is marked as public symbols
robertmaynard Jun 11, 2024
c99a58c
Add needed visibility patches for CCCL
robertmaynard Jun 11, 2024
0017f41
CMake now builds cudf and test util with hidden vis
robertmaynard Jun 10, 2024
162eb78
Correct style issue found by CI
robertmaynard Jun 12, 2024
7ee6fd7
Mark more detail functions as public
robertmaynard Jul 9, 2024
13f247d
Search src files include respective header
robertmaynard Jul 10, 2024
2b301e3
Restore child_columns_to_device_array
robertmaynard Jul 10, 2024
ae631cf
Added chunked_parquet_reader constructor comments
robertmaynard Jul 10, 2024
26986ef
Correct style issues found by CI
robertmaynard Jul 10, 2024
bc79512
Add missing header so copy symbols get marked as public
robertmaynard Jul 11, 2024
28d34df
Correctly mark all detail functions as public
robertmaynard Jul 11, 2024
df8ba16
Correct style issues found by CI
robertmaynard Jul 11, 2024
ed88b30
Add first pass doc update
robertmaynard Jul 11, 2024
bc85b9f
Update java/src/main/native/src/TableJni.cpp
robertmaynard Jul 11, 2024
d2261b5
Debug java missing symbols
robertmaynard Jul 15, 2024
c127579
Ensure lists::detail::concatenate is public
robertmaynard Jul 15, 2024
97541e6
Ensure include headers are marked with CUDF_EXPORT
robertmaynard Jul 17, 2024
22a6f24
more doc updates
robertmaynard Jul 22, 2024
642713a
Merge branch 'branch-24.08' into fea/hide_visibility_of_non_public_sy…
robertmaynard Jul 22, 2024
cd9d68b
Expose prefect API via CUDF_EXPORT
robertmaynard Jul 23, 2024
9c9200c
Merge branch 'branch-24.08' into fea/hide_visibility_of_non_public_sy…
robertmaynard Jul 23, 2024
90ada43
Expose io::json::detail as they are required by tests
robertmaynard Jul 23, 2024
b012799
Merge branch 'branch-24.08' into fea/hide_visibility_of_non_public_sy…
robertmaynard Jul 24, 2024
3784f33
Merge branch 'branch-24.08' into fea/hide_visibility_of_non_public_sy…
robertmaynard Jul 24, 2024
d76ebb7
Merge branch 'branch-24.08' into fea/hide_visibility_of_non_public_sy…
bdice Jul 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cudftestutil public API is marked as public symbols
  • Loading branch information
robertmaynard committed Jul 17, 2024
commit 9f0ffd0283bf05e424f392e2cebdae0e73ec5911
3 changes: 2 additions & 1 deletion cpp/include/cudf_test/base_fixture.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,14 @@
#include <cudf_test/cudf_gtest.hpp>
#include <cudf_test/file_utilities.hpp>

#include <cudf/utilities/export.hpp>
#include <cudf/utilities/traits.hpp>

#include <rmm/mr/device/device_memory_resource.hpp>
#include <rmm/mr/device/per_device_resource.hpp>
#include <rmm/resource_ref.hpp>

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {

/**
Expand Down
9 changes: 7 additions & 2 deletions cpp/include/cudf_test/column_utilities.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@
#include <cudf/strings/strings_column_view.hpp>
#include <cudf/types.hpp>
#include <cudf/utilities/default_stream.hpp>
#include <cudf/utilities/export.hpp>
#include <cudf/utilities/error.hpp>

#include <thrust/host_vector.h>
#include <thrust/iterator/transform_iterator.h>

namespace cudf::test {
namespace CUDF_EXPORT cudf {
namespace test {

/**
* @brief Verbosity level of output from column and table comparison functions.
Expand Down Expand Up @@ -194,6 +196,7 @@ std::pair<thrust::host_vector<T>, std::vector<bitmask_type>> to_host(column_view
* `column_view`'s data, and second is the column's bitmask.
*/
template <typename T, std::enable_if_t<cudf::is_fixed_point<T>()>* = nullptr>
CUDF_EXPORT
std::pair<thrust::host_vector<T>, std::vector<bitmask_type>> to_host(column_view c);

/**
Expand All @@ -207,6 +210,7 @@ std::pair<thrust::host_vector<T>, std::vector<bitmask_type>> to_host(column_view
* and second is the column's bitmask.
*/
template <>
CUDF_EXPORT
std::pair<thrust::host_vector<std::string>, std::vector<bitmask_type>> to_host(column_view c);
//! @endcond

Expand All @@ -233,7 +237,8 @@ struct large_strings_enabler {
void disable();
};

} // namespace cudf::test
} // namespace test
} // namespace cudf

// Macros for showing line of failure.
#define CUDF_TEST_EXPECT_COLUMN_PROPERTIES_EQUAL(lhs, rhs) \
Expand Down
3 changes: 2 additions & 1 deletion cpp/include/cudf_test/column_wrapper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <cudf/null_mask.hpp>
#include <cudf/types.hpp>
#include <cudf/utilities/bit.hpp>
#include <cudf/utilities/export.hpp>
#include <cudf/utilities/default_stream.hpp>
#include <cudf/utilities/traits.hpp>
#include <cudf/utilities/type_dispatcher.hpp>
Expand All @@ -50,7 +51,7 @@
#include <memory>
#include <numeric>

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {
namespace detail {
/**
Expand Down
9 changes: 6 additions & 3 deletions cpp/include/cudf_test/debug_utilities.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2023, NVIDIA CORPORATION.
* Copyright (c) 2020-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -18,8 +18,10 @@

#include <cudf/column/column_view.hpp>
#include <cudf/null_mask.hpp>
#include <cudf/utilities/export.hpp>

namespace cudf::test {
namespace CUDF_EXPORT cudf {
namespace test {

/**
* @brief Formats a column view as a string
Expand All @@ -44,4 +46,5 @@ std::vector<std::string> to_strings(cudf::column_view const& col);
*/
void print(cudf::column_view const& col, std::ostream& os = std::cout);

} // namespace cudf::test
} // namespace test
} // namespace cudf
6 changes: 4 additions & 2 deletions cpp/include/cudf_test/default_stream.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022-2023, NVIDIA CORPORATION.
* Copyright (c) 2022-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -16,9 +16,11 @@

#pragma once

#include <cudf/utilities/export.hpp>

#include <rmm/cuda_stream_view.hpp>

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {

/**
Expand Down
3 changes: 2 additions & 1 deletion cpp/include/cudf_test/file_utilities.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cudf/utilities/export.hpp>
#include <cudf/utilities/error.hpp>

#include <ftw.h>
Expand All @@ -29,7 +30,7 @@
* @brief RAII class for creating a temporary directory.
*
*/
class temp_directory {
class CUDF_EXPORT temp_directory {
std::string _path;

public:
Expand Down
9 changes: 6 additions & 3 deletions cpp/include/cudf_test/io_metadata_utilities.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2022, NVIDIA CORPORATION.
* Copyright (c) 2021-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -16,8 +16,10 @@
#pragma once

#include <cudf/io/types.hpp>
#include <cudf/utilities/export.hpp>

namespace cudf::test {
namespace CUDF_EXPORT cudf {
namespace test {

void expect_metadata_equal(cudf::io::table_input_metadata in_meta,
cudf::io::table_metadata out_meta);
Expand All @@ -28,4 +30,5 @@ void expect_metadata_equal(cudf::io::table_input_metadata in_meta,
*/
void expect_metadata_equal(cudf::io::table_metadata lhs_meta, cudf::io::table_metadata rhs_meta);

} // namespace cudf::test
} // namespace test
} // namespace cudf
5 changes: 3 additions & 2 deletions cpp/include/cudf_test/iterator_utilities.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2023, NVIDIA CORPORATION.
* Copyright (c) 2021-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -18,13 +18,14 @@

#include <cudf/detail/iterator.cuh>
#include <cudf/types.hpp>
#include <cudf/utilities/export.hpp>

#include <thrust/iterator/constant_iterator.h>
#include <thrust/iterator/transform_iterator.h>

#include <iterator>

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {
namespace iterators {
/**
Expand Down
7 changes: 5 additions & 2 deletions cpp/include/cudf_test/print_utilities.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#pragma once

#include <cudf/types.hpp>
#include <cudf/utilities/export.hpp>
#include <cudf/utilities/traits.hpp>

#include <rmm/cuda_stream_view.hpp>
Expand All @@ -25,7 +26,8 @@

#include <type_traits>

namespace cudf::test::print {
namespace CUDF_EXPORT {
namespace test::print {

constexpr int32_t hex_tag = 0;

Expand Down Expand Up @@ -137,4 +139,5 @@ void print_array(std::size_t count, rmm::cuda_stream_view stream, Ts... args)
}
}

} // namespace cudf::test::print
} // namespace test::print
} // namespace CUDF_EXPORT
3 changes: 2 additions & 1 deletion cpp/include/cudf_test/random.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@

#pragma once

#include <cudf/utilities/export.hpp>
#include <cudf/utilities/traits.hpp>

#include <random>

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {

template <typename T, typename Enable = void>
Expand Down
9 changes: 6 additions & 3 deletions cpp/include/cudf_test/table_utilities.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019-2022, NVIDIA CORPORATION.
* Copyright (c) 2019-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -18,8 +18,10 @@

#include <cudf/table/table_view.hpp>
#include <cudf/types.hpp>
#include <cudf/utilities/export.hpp>

namespace cudf::test::detail {
namespace CUDF_EXPORT cudf {
namespace test::detail {
/**
* @brief Verifies the property equality of two tables.
*
Expand Down Expand Up @@ -57,7 +59,8 @@ void expect_tables_equal(cudf::table_view lhs, cudf::table_view rhs);
*/
void expect_tables_equivalent(cudf::table_view lhs, cudf::table_view rhs);

} // namespace cudf::test::detail
} // namespace test::detail
} // namespace cudf

// Macros for showing line of failure.
#define CUDF_TEST_EXPECT_TABLE_PROPERTIES_EQUAL(lhs, rhs) \
Expand Down
5 changes: 3 additions & 2 deletions cpp/include/cudf_test/tdigest_utilities.cuh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022-2023, NVIDIA CORPORATION.
* Copyright (c) 2022-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -23,6 +23,7 @@
#include <cudf/groupby.hpp>
#include <cudf/tdigest/tdigest_column_view.hpp>
#include <cudf/utilities/default_stream.hpp>
#include <cudf/utilities/export.hpp>

#include <rmm/exec_policy.hpp>
#include <rmm/mr/device/per_device_resource.hpp>
Expand All @@ -37,7 +38,7 @@

// for use with groupby and reduction aggregation tests.

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {

using expected_value = thrust::tuple<size_type, double, double>;
Expand Down
3 changes: 2 additions & 1 deletion cpp/include/cudf_test/testing_main.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <cudf_test/stream_checking_resource_adaptor.hpp>

#include <cudf/utilities/error.hpp>
#include <cudf/utilities/export.hpp>

#include <rmm/aligned.hpp>
#include <rmm/cuda_stream_view.hpp>
Expand All @@ -32,7 +33,7 @@
#include <rmm/mr/device/per_device_resource.hpp>
#include <rmm/mr/device/pool_memory_resource.hpp>

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {

/// MR factory functions
Expand Down
3 changes: 2 additions & 1 deletion cpp/include/cudf_test/timestamp_utilities.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,13 @@
#include <cudf_test/column_wrapper.hpp>

#include <cudf/detail/iterator.cuh>
#include <cudf/utilities/export.hpp>
#include <cudf/wrappers/timestamps.hpp>

#include <thrust/logical.h>
#include <thrust/sequence.h>

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {
using time_point_ms =
cuda::std::chrono::time_point<cuda::std::chrono::system_clock, cuda::std::chrono::milliseconds>;
Expand Down
6 changes: 4 additions & 2 deletions cpp/include/cudf_test/type_list_utilities.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019-2023, NVIDIA CORPORATION.
* Copyright (c) 2019-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -17,6 +17,8 @@

#include "cudf_gtest.hpp"

#include <cudf/utilities/export.hpp>

/**
* @file type_list_utilities.hpp
* @brief Utilities for creating type lists for typed tests in Google Test
Expand Down Expand Up @@ -68,7 +70,7 @@
* increased compile-times. Use responsibly.
*/

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {
// Utilities for creating parameters for typed tests on GoogleTest
//
Expand Down
3 changes: 2 additions & 1 deletion cpp/include/cudf_test/type_lists.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <cudf/fixed_point/fixed_point.hpp>
#include <cudf/strings/string_view.hpp>
#include <cudf/types.hpp>
#include <cudf/utilities/export.hpp>
#include <cudf/utilities/traits.hpp>
#include <cudf/utilities/type_dispatcher.hpp>
#include <cudf/wrappers/durations.hpp>
Expand All @@ -40,7 +41,7 @@
* These lists should be used for consistency across tests as well as
* future-proofing against the addition of any new types in the future.
*/
namespace cudf {
namespace CUDF_EXPORT cudf {
namespace test {
namespace detail {
template <typename TYPES, std::size_t... Indices>
Expand Down
4 changes: 2 additions & 2 deletions cpp/tests/utilities/random_seed.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, NVIDIA CORPORATION.
* Copyright (c) 2020-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -23,7 +23,7 @@ namespace detail {
/**
* @copydoc cudf::test::detail::random_generator_incrementing_seed()
*/
uint64_t random_generator_incrementing_seed()
CUDF_EXPORT uint64_t random_generator_incrementing_seed()
{
static uint64_t seed = 0;
return ++seed;
Expand Down