Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise FileNotFoundError when a literal JSON string that looks like a json filename is passed #15806

Merged
merged 4 commits into from
May 22, 2024
Merged

Raise FileNotFoundError when a literal JSON string that looks like a json filename is passed #15806

merged 4 commits into from
May 22, 2024

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented May 21, 2024 •
edited
Loading

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lithomas1 lithomas1 requested a review from a team as a code owner May 21, 2024 19:56
@lithomas1 lithomas1 requested review from vyasr and isVoid May 21, 2024 19:56
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 21, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Python Affects Python cuDF API. label May 21, 2024
@quasiben
Copy link
Member

/ok to test

@vyasr vyasr added improvement Improvement / enhancement to an existing function breaking Breaking change labels May 21, 2024
@lithomas1
Copy link
Contributor Author

Talked on slack with Vyas, we concluded that it's probably too early to rip this stuff out.

We probably can be a bit smarter for cases where a JSON string looks like a json filename, though.

the relevant logic for pandas is https://github.com/pandas-dev/pandas/pull/46718/files#diff-472ce5fe087e67387942e1e1c409a5bc58dde9eb8a2db6877f1a45ae4974f694R724-R728

@lithomas1 lithomas1 force-pushed the remove-json-string branch from 03f9f0c to 45cd092 Compare May 21, 2024 22:50
@lithomas1 lithomas1 changed the title Remove reading literal string in cudf.read_json Raise FileNotFoundError when a literal JSON string that looks like a json filename is passed May 21, 2024
@lithomas1 lithomas1 force-pushed the remove-json-string branch from 45cd092 to a7af4a4 Compare May 21, 2024 23:25
@mroeschke
Copy link
Contributor

/ok to test

@vyasr
Copy link
Contributor

vyasr commented May 22, 2024

Looks great to me!

@vyasr
Copy link
Contributor

vyasr commented May 22, 2024

/merge

@rapids-bot rapids-bot bot merged commit ad56bc3 into rapidsai:branch-24.06 May 22, 2024
70 checks passed
@lithomas1 lithomas1 deleted the remove-json-string branch May 22, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- left review comments

@vyasr vyasr vyasr approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cudf.read_json returns ValueError when given file is not found
5 participants
@lithomas1 @quasiben @mroeschke @vyasr @wence-