Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spaces around CSV quoted strings #15727

Merged
merged 9 commits into from
May 22, 2024
Merged

Fix spaces around CSV quoted strings #15727

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e7351fa
Remove leading and trailing whitespace around CSV quoted strings
thabetx Apr 20, 2024
a0e8ed0
update comment
thabetx Apr 29, 2024
b964112
add flag to preserve old behavior
thabetx May 11, 2024
1cc8e4d
change expect to assert in test
thabetx May 17, 2024
39b6e94
restore accidentally removed code
thabetx May 17, 2024
27c126f
format
thabetx May 17, 2024
be1bb6b
rename `_updated_quotes_detection` to `_detect_whitespace_around_quot…
thabetx May 18, 2024
6ae3ee1
Merge branch 'branch-24.06' into fix-spaces-around-quoted-strings
thabetx May 18, 2024
dfa45b1
Merge branch 'branch-24.06' into fix-spaces-around-quoted-strings
shrshi May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comment
  • Loading branch information
@thabetx
thabetx committed May 11, 2024
commit a0e8ed0bac260351311b7b6bddee995fc3aec1ef
2 changes: 1 addition & 1 deletion cpp/src/io/csv/csv_gpu.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ CUDF_KERNEL void __launch_bounds__(csvparse_block_dim)
if (dtypes[actual_col].id() == cudf::type_id::STRING) {
auto end = next_delimiter;
if (not options.keepquotes) {
// Remove whitepaces only if there are quotes
// If the string is quoted, whitespace around the quotes get removed as well
auto const trimmed_field =
trim_whitespaces(field_start, end);
if ((*trimmed_field.first == options.quotechar) && (*(trimmed_field.second-1) == options.quotechar)) {
Expand Down