Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make_offsets_child_column usage in cudf::strings::detail::shift #15630

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix make_offsets_child_column usage in cudf::strings::detail::shift #15630

merged 1 commit into from
May 3, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes the cudf::strings::detail::shift() function to use the correct make_offsets_child_column function to support large strings.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 1, 2024
@davidwendt davidwendt self-assigned this May 1, 2024
@davidwendt davidwendt requested a review from a team as a code owner May 1, 2024 17:28
@davidwendt davidwendt requested review from vyasr and mhaseeb123 May 1, 2024 17:28
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c60860d into rapidsai:branch-24.06 May 3, 2024
71 checks passed
@davidwendt davidwendt deleted the mocc-shift branch May 3, 2024 13:03
@davidwendt davidwendt mentioned this pull request May 28, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Jun 3, 2024
@davidwendt
Use offsetalator in strings shift functor (#15870)
f30ea0a 
Replaces hardcoded `size_type` used for offset values in the `shift_chars_fn` functor with offsetalator.
Follow on to #15630

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Paul Mattione (https://github.com/pmattione-nvidia)
  - Yunsong Wang (https://github.com/PointKernel)

URL: #15870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @mhaseeb123