Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct pylibcudf columns from objects supporting __cuda_array_interface__ #15615

Merged
merged 10 commits into from
May 2, 2024
Merged

Construct pylibcudf columns from objects supporting __cuda_array_interface__ #15615

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4b55227
initial
brandon-b-miller Apr 25, 2024
ea9f9b5
cleanup
brandon-b-miller Apr 25, 2024
5805a0e
Apply suggestions from code review
brandon-b-miller Apr 30, 2024
37cfb75
Merge branch 'branch-24.06' into pylibcudf-col-from-cuda-iface
brandon-b-miller Apr 30, 2024
2a86b37
cache dtype lookup
brandon-b-miller Apr 30, 2024
3a50093
fix bool test
brandon-b-miller Apr 30, 2024
52715d2
do not module scope fixtures unnecessarily
brandon-b-miller Apr 30, 2024
7312c73
raise if mask is populated but not if interface is missing
brandon-b-miller Apr 30, 2024
d5b6ba8
Merge branch 'branch-24.06' into pylibcudf-col-from-cuda-iface
brandon-b-miller May 1, 2024
0736605
move is_c_contiguous and use it
brandon-b-miller May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix bool test
  • Loading branch information
@brandon-b-miller
brandon-b-miller committed Apr 30, 2024
commit 3a50093282661e98c055ecc9fbfd60647575442f
2 changes: 2 additions & 0 deletions python/cudf/cudf/pylibcudf_tests/test_column_from_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ def valid_type(request):

@pytest.fixture(scope="module")
def valid_column(valid_type):
if valid_type == pa.bool_():
return pa.array([True, False, True], type=valid_type)
return pa.array([1, 2, 3], type=valid_type)


Expand Down