Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding of dictionary encoded FIXED_LEN_BYTE_ARRAY data in Parquet reader #15601

Merged
merged 10 commits into from
May 7, 2024
Merged

Fix decoding of dictionary encoded FIXED_LEN_BYTE_ARRAY data in Parquet reader #15601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
79cb851
build string dictionaries for FLBA
etseidl Apr 25, 2024
0b311e0
take FLBA into account when building string dict index
etseidl Apr 25, 2024
99e0cfa
add test and fix initialization of dict_base
etseidl Apr 26, 2024
ce99d2e
clean up test of dict length
etseidl Apr 26, 2024
fc1bda0
simplification
etseidl Apr 26, 2024
a2438ae
Merge branch 'branch-24.06' into flba_dict_decode
vuule Apr 26, 2024
9e0c85e
Merge branch 'branch-24.06' into flba_dict_decode
etseidl Apr 30, 2024
74e8f4f
Merge branch 'rapidsai:branch-24.06' into flba_dict_decode
etseidl May 2, 2024
afa5894
Merge branch 'branch-24.06' into flba_dict_decode
etseidl May 3, 2024
d201655
Merge branch 'branch-24.06' into flba_dict_decode
vuule May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up test of dict length
  • Loading branch information
@etseidl
etseidl committed Apr 26, 2024
commit ce99d2e068b515f6c0a700c54671237947e8ce49
2 changes: 0 additions & 2 deletions cpp/src/io/parquet/page_decode.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
#pragma once

#include "error.hpp"
#include "io/parquet/parquet.hpp"
#include "io/utilities/block_utils.cuh"
#include "parquet_common.hpp"
#include "parquet_gpu.hpp"
#include "rle_stream.cuh"

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/io/parquet/page_hdr.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ CUDF_KERNEL void __launch_bounds__(128)
for (int i = 0; i < num_entries; i++) {
int len = 0;
if (ck->physical_type == FIXED_LEN_BYTE_ARRAY) {
if (cur < dict_size) {
if (cur + ck->type_length <= dict_size) {
len = ck->type_length;
pos = cur;
cur += len;
Expand Down
1 change: 0 additions & 1 deletion cpp/src/io/parquet/reader_impl_preprocess.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

#include "error.hpp"
#include "io/parquet/parquet_common.hpp"
#include "reader_impl.hpp"

#include <cudf/detail/iterator.cuh>
Expand Down