Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update developer guide with device_async_resource_ref guidelines #15562

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Update developer guide with device_async_resource_ref guidelines #15562

merged 7 commits into from
Apr 29, 2024

Conversation

harrism
Copy link
Member

@harrism harrism commented Apr 17, 2024

Description

Closes #15561

Updates guidance in libcudf DEVELOPER_GUIDE.md to cover resource refs and change examples to not use device_memory_resource pointers.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism added doc Documentation non-breaking Non-breaking change labels Apr 17, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 17, 2024
@harrism harrism marked this pull request as ready for review April 17, 2024 23:25
@harrism harrism requested a review from a team as a code owner April 17, 2024 23:25
@harrism harrism requested review from vyasr, pmattione-nvidia and bdice and removed request for bdice April 17, 2024 23:25
@harrism @bdice
Fix typos
064fb8b 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@harrism
Copy link
Member Author

harrism commented Apr 29, 2024

/merge

@rapids-bot rapids-bot bot merged commit ab5e3f3 into rapidsai:branch-24.06 Apr 29, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@pmattione-nvidia pmattione-nvidia pmattione-nvidia approved these changes

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Update DEVELOPER_GUIDE.md after conversion to rmm::device_async_resource_ref
5 participants
@harrism @bdice @ttnghia @pmattione-nvidia @wence-