Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce benchmark suite for JSON reader options #15124

Merged
merged 22 commits into from
Apr 9, 2024
Merged
Changes from 3 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b2a7c45
simple json lines benchmark - no fancy data generation
shrshi Feb 23, 2024
bc42243
style fixes
shrshi Feb 23, 2024
f2dd994
added lines; table size as param
shrshi Feb 28, 2024
2ae3633
Merge branch 'branch-24.04' into json-benchmark
shrshi Feb 28, 2024
ea4d9b7
Merge branch 'branch-24.04' into json-benchmark
shrshi Mar 4, 2024
56317bd
Merge branch 'branch-24.04' into json-benchmark
shrshi Mar 6, 2024
a1bc431
Merge branch 'branch-24.04' into json-benchmark
shrshi Mar 7, 2024
5c0de81
partial work commit
shrshi Mar 8, 2024
72b070d
adding whitespace normalization and lines axes
shrshi Mar 8, 2024
e04db8b
separated out the lines benchamrk
shrshi Mar 8, 2024
b470334
Merge branch 'json-benchmark' of github.com:shrshi/cudf into json-ben…
shrshi Mar 8, 2024
dc799c2
Merge branch 'branch-24.04' into json-benchmark
shrshi Mar 8, 2024
f926172
skipping some param configs
shrshi Mar 11, 2024
6c75aee
Merge branch 'json-benchmark' of github.com:shrshi/cudf into json-ben…
shrshi Mar 11, 2024
14435e0
Merge branch 'branch-24.04' into json-benchmark
shrshi Mar 11, 2024
5f331e2
partially addressing PR reviews
shrshi Mar 11, 2024
6c3604b
Merge branch 'branch-24.04' into json-benchmark
shrshi Mar 19, 2024
5661a4a
Update cpp/benchmarks/io/json/json_reader_option.cpp
shrshi Mar 19, 2024
12cfaba
Merge branch 'branch-24.04' into json-benchmark
shrshi Mar 19, 2024
300753c
Merge branch 'json-benchmark' of github.com:shrshi/cudf into json-ben…
shrshi Mar 19, 2024
3a79368
formatting fix
shrshi Mar 19, 2024
66552a5
Merge branch 'branch-24.06' into json-benchmark
ttnghia Apr 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cpp/benchmarks/io/json/json_reader_option.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,10 @@ void BM_json_read_options(nvbench::state& state, nvbench::type_list<nvbench::enu
state.exec(
nvbench::exec_tag::sync | nvbench::exec_tag::timer, [&](nvbench::launch& launch, auto& timer) {
try_drop_l3_cache();
cudf::size_type num_rows_read = 0;
cudf::size_type num_cols_read = 0;
timer.start();
auto const result = cudf::io::read_json(read_options);
num_rows_read = result.tbl->num_rows();
num_cols_read = result.tbl->num_columns();
auto const num_rows_read = result.tbl->num_rows();
auto const num_cols_read = result.tbl->num_columns();
timer.stop();
CUDF_EXPECTS(num_rows_read == view.num_rows(), "Benchmark did not read the entire table");
CUDF_EXPECTS(num_cols_read == num_cols, "Unexpected number of columns");
Expand Down