-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the java API so a global default host allocator can be set. #15026
base: branch-24.04
Are you sure you want to change the base?
Conversation
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me.
@revans2 did this stall for any particular reason? Do we want to get this merged? |
@vyasr It stalled because of other priorities, and this is not technically a requirement. I'll probably get back to it once all of the JSON work I am doing is done. If you want me to close it/retarget it to a different release I am happy to do it. |
No problem. We can keep it open if you plan to come back to it, and you can retarget it then. I just wanted to clean it up if it should be either merged soon or closed as a wontfix. |
Description
Originally the design for host memory limits wanted to give us the ability to do different things for different operations. That changed and now we really just want to set a global allocator instead.
In addition this removed host memory reservations, which was part of the original design, but is no longer needed and would be hard to maintain. It also adds in a Raw allocation API so that we can wrap the original allocation API if needed.
Note that this is a braking change not only because it is removing some unused features but it changes some APIs that some downstream projects are using, which will require the downstream project to have a patch ready to go to avoid breaking.
Checklist