-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor numpy array input in as_column #14651
Merged
rapids-bot
merged 35 commits into
rapidsai:branch-24.06
from
mroeschke:ref/np_array_handling
Apr 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
aac2c1e
Refactor numpy array input in as_column
mroeschke 5afd82c
Merge remote-tracking branch 'upstream/branch-24.02' into ref/np_arra…
mroeschke 18be5c0
make bool and int data go through arrow
mroeschke 1eb5cf0
Merge remote-tracking branch 'upstream/branch-24.02' into ref/np_arra…
mroeschke ac403ca
Fix typo, just build buffer again for datelike types
mroeschke 2655e26
Merge remote-tracking branch 'upstream/branch-24.02' into ref/np_arra…
mroeschke e192238
Fix ==
mroeschke 8778e29
Treat NAs in np array as NULL with arrow
mroeschke dbca8d4
Merge remote-tracking branch 'upstream/branch-24.02' into ref/np_arra…
mroeschke 2013017
Merge remote-tracking branch 'upstream/branch-24.02' into ref/np_arra…
mroeschke e75893a
Reuse is_nat
mroeschke bdb8da0
Add comments about NaT behavior
mroeschke b39a75e
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke 94baa34
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke edd2080
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke 66d4403
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke ba963ad
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke 192f376
Trigger CI
mroeschke 1c923b4
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke 1917103
Fix some tests
mroeschke 99c1419
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke a969b84
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke 92856de
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke 147ba2b
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke ef56817
fix some concat tests
mroeschke ab5d10f
Dont create mask if no NAs
mroeschke e2fb5b4
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke 96f1491
Fix test, add error for unitless datetlike
mroeschke 912e5b9
Merge remote-tracking branch 'upstream/branch-24.04' into ref/np_arra…
mroeschke 95ae6b2
Merge remote-tracking branch 'upstream/branch-24.06' into ref/np_arra…
mroeschke bee6c91
Merge remote-tracking branch 'upstream/branch-24.06' into ref/np_arra…
mroeschke 2c64990
Address review
mroeschke 4d57148
Merge remote-tracking branch 'upstream/branch-24.06' into ref/np_arra…
mroeschke 3ffd9e6
Remove carveout for np array of cupy objects
mroeschke 15fff60
Merge remote-tracking branch 'upstream/branch-24.06' into ref/np_arra…
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Dont create mask if no NAs
- Loading branch information
commit ab5d10fc13ffb534f5dace5fff899e4139d6e518
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superfluous else since we're returning above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Removed