Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for illegal instruction error in sm90 for warp instrinsics with mask #14201

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Workaround for illegal instruction error in sm90 for warp instrinsics with mask #14201

merged 2 commits into from
Sep 27, 2023

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented Sep 26, 2023 •
edited by harrism
Loading

Description

Workaround for illegal instruction error in sm90 for warp instrinsics with non 0xffffffff mask
Removed the mask, and used ~0u (0xffffffff) as MASK because

  • all threads in warp has correct data on error since is_within_bounds==true thread update error.
  • init_state is not required at last iteration only where MASK is not ~0u.

Fixes #14183

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann
workaround for illegal instruction error in sm90 for
afc1541 
warp instrinsics with non ~0 mask
@karthikeyann karthikeyann added bug Something isn't working 3 - Ready for Review Ready for review by team cuda libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond cuIO cuIO issue non-breaking Non-breaking change labels Sep 26, 2023
@karthikeyann karthikeyann requested a review from a team as a code owner September 26, 2023 18:31
@karthikeyann karthikeyann self-assigned this Sep 26, 2023
@divyegala
Copy link
Member

@karthikeyann do you know when the illegal instruction bug is going to be fixed?

divyegala
divyegala approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the NVBug in this PR description?

@karthikeyann
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 31e5670 into rapidsai:branch-23.10 Sep 27, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@elstehle elstehle elstehle approved these changes

@harrism harrism harrism approved these changes

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Runtime error with read_json in 23.10
5 participants
@karthikeyann @divyegala @harrism @elstehle @vyasr