Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various issues in Index.intersection #14054

Merged
merged 9 commits into from
Sep 12, 2023
Merged

Fix various issues in Index.intersection #14054

merged 9 commits into from
Sep 12, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Sep 7, 2023 •
edited
Loading

Description

This PR fixes multiple issues with Index.intersection:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Sep 7, 2023
@galipremsagar galipremsagar self-assigned this Sep 7, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner September 7, 2023 05:29
bdice
bdice reviewed Sep 11, 2023
View reviewed changes
python/cudf/cudf/core/_base_index.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/_base_index.py Outdated Show resolved Hide resolved
bdice
bdice reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refactoring ideas.

python/cudf/cudf/core/_base_index.py Outdated Show resolved Hide resolved
python/cudf/cudf/utils/dtypes.py Outdated Show resolved Hide resolved
bdice
bdice approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galipremsagar you mentioned this was blocking some other work -- if you'd like to move it forward and then follow up on the refactoring steps that I mentioned in comments, go ahead. I don't think those refactorings are crucial, just nice-to-have. Approving.

@galipremsagar
Copy link
Contributor Author

@galipremsagar you mentioned this was blocking some other work -- if you'd like to move it forward and then follow up on the refactoring steps that I mentioned in comments, go ahead. I don't think those refactorings are crucial, just nice-to-have. Approving.

Addressed the refactor reviews in this PR. Thanks @bdice !

@galipremsagar
Copy link
Contributor Author

Merging this, @bdice if you think there is more to be addressed let me know I'll tackle it in a follow-up PR.

@galipremsagar
Copy link
Contributor Author

/merge

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 12, 2023
@rapids-bot rapids-bot bot merged commit 1911d33 into rapidsai:branch-23.10 Sep 12, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Index.intersection throwing error on empty inputs
2 participants
@galipremsagar @bdice