Provide our own Cython declaration for make_unique #13746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
force-pushed
the
wence/fix/issue-13743
branch
from
111ce41
to
58631f8
Compare
shwina
approved these changes
Jul 25, 2023
|
Let's re-target this to 23.10 |
wence-
force-pushed
the
wence/fix/issue-13743
branch
from
58631f8
to
758483d
Compare
github-actions
bot
added
libcudf
make_unique in Cython's libcpp headers is not annotated with `except +`. As a consequence, if the constructor throws, we do not catch it in Python. To work around this (see cython/cython#5560 for details), provide our own implementation. Due to the way assignments occur to temporaries, we need to now explicitly wrap all calls to `make_unique` in `move`, but that is arguably preferable to not being able to catch exceptions, and will not be necessary once we move to Cython 3. - Closes rapidsai#13743
wence-
force-pushed
the
wence/fix/issue-13743
branch
from
758483d
to
ab77c9f
Compare
github-actions
bot
removed
libcudf
Done. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make_uniquein Cython's libcpp headers is not annotated withexcept +. As a consequence, if the constructor throws, we do not catch it in Python. To work around this (see cython/cython#5560 for details), provide our own implementation.Due to the way assignments occur to temporaries, we need to now explicitly wrap all calls to
make_uniqueinmove, but that is arguably preferable to not being able to catch exceptions, and will not be necessary once we move to Cython 3.Checklist