Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to arrow 12 #13728

Merged
merged 14 commits into from
Jul 31, 2023
Merged

Upgrade to arrow 12 #13728

merged 14 commits into from
Jul 31, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jul 21, 2023

Description

This PR upgrades arrow version in cudf to 12.0.1

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue conda labels Jul 21, 2023
@vyasr vyasr mentioned this pull request Jul 27, 2023
3 tasks
@github-actions github-actions bot added the ci label Jul 28, 2023
@github-actions github-actions bot removed the ci label Jul 28, 2023
@galipremsagar galipremsagar marked this pull request as ready for review July 29, 2023 02:53
@galipremsagar galipremsagar requested review from a team as code owners July 29, 2023 02:53
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function breaking Breaking change labels Jul 29, 2023
@galipremsagar galipremsagar self-assigned this Jul 29, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9d465f2 into rapidsai:branch-23.10 Jul 31, 2023
54 checks passed
@bdice
Copy link
Contributor

bdice commented Jul 31, 2023

🏹 🎉 Thanks @galipremsagar!

rapids-bot bot pushed a commit that referenced this pull request Aug 4, 2023
This PR contains the minimal set of changes to compile using Cython 3 without warnings. Future PRs can be made to take advantage of new or improved features.

The specific changes are:
- Ensuring `nogil` always comes after `except`. `except * nogil` is a compile-time error in Cython 3
- Removing any extern cdef functions that uses C++ rvalues. These were never supported by Cython, but prior to 3.0 they were silently ignored whereas now Cython throws warnings during compilation
- Relative imports are no longer off by one level in pxd files and must be adjusted accordingly (see cython/cython#3442)

There are a large number of outstanding warnings due to NVIDIA/cuda-python#44. cuda-python for CUDA 12 has the necessary fix, but we will need a cuda-python 11.8.* bugfix with a backport to make those warnings go away.

There are also warnings coming from pyarrow due to apache/arrow#34564. pyarrow 12 contains the necessary fixes, so this issues should be resolved once #13728 is merged.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Bradley Dice (https://github.com/bdice)
  - Benjamin Zaitlen (https://github.com/quasiben)
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - https://github.com/jakirkham

URL: #13777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants