Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash join when the input tables have nulls on only one side #13120

Merged
merged 22 commits into from
Apr 13, 2023
Merged

Fix hash join when the input tables have nulls on only one side #13120

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d9a36b5
Add `has_nulls` parameter
ttnghia Apr 11, 2023
4244f0c
Adopt changes
ttnghia Apr 11, 2023
e9a7543
Fix JNI
ttnghia Apr 11, 2023
dca4347
Fix join tests
ttnghia Apr 11, 2023
4774783
Add test
ttnghia Apr 11, 2023
779db50
Merge branch 'branch-23.06' into fix_hash_join
ttnghia Apr 11, 2023
21f1020
Fix copyright headers
ttnghia Apr 11, 2023
eba48de
Fix benchmark code
ttnghia Apr 11, 2023
aaf3a52
Revert "Fix JNI"
ttnghia Apr 12, 2023
b09a391
Add overload constructor and add docs
ttnghia Apr 12, 2023
c38f580
Fix docs
ttnghia Apr 12, 2023
3bbb7a1
Change tests
ttnghia Apr 12, 2023
22d2651
Fix docs
ttnghia Apr 12, 2023
c8a5af6
Update cpp/include/cudf/detail/join.hpp
ttnghia Apr 12, 2023
30e884c
Implement `nullable_join`
ttnghia Apr 12, 2023
df2f871
Move `nullable_join` enum out of `hash_join` class
ttnghia Apr 12, 2023
00ec0a9
Fix compile issues
ttnghia Apr 12, 2023
2f2e467
Merge branch 'branch-23.06' into fix_hash_join
ttnghia Apr 12, 2023
00c2ecc
Change docs
ttnghia Apr 12, 2023
bdeadd3
Merge branch 'branch-23.06' into fix_hash_join
vyasr Apr 13, 2023
8ff3d64
Fix benchmark code
ttnghia Apr 13, 2023
6a3c217
Fix join benchmark
ttnghia Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix benchmark code
  • Loading branch information
@ttnghia
ttnghia committed Apr 13, 2023
commit 8ff3d64a594de70328a0b6349b5ddd8fedbde5e7
6 changes: 3 additions & 3 deletions cpp/benchmarks/join/join.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ void nvbench_inner_join(nvbench::state& state,
cudf::has_nested_nulls(left_input) || cudf::has_nested_nulls(right_input),
compare_nulls,
stream);
return hj_obj.inner_join(right_input, std::nullopt, stream);
return hj_obj.inner_join(right_input, stream);
};

BM_join<key_type, payload_type, Nullable>(state, join);
Expand All @@ -53,7 +53,7 @@ void nvbench_left_join(nvbench::state& state,
cudf::has_nested_nulls(left_input) || cudf::has_nested_nulls(right_input),
compare_nulls,
stream);
return hj_obj.left_join(right_input, std::nullopt, stream);
return hj_obj.left_join(right_input, stream);
};

BM_join<key_type, payload_type, Nullable>(state, join);
Expand All @@ -74,7 +74,7 @@ void nvbench_full_join(nvbench::state& state,
cudf::has_nested_nulls(left_input) || cudf::has_nested_nulls(right_input),
compare_nulls,
stream);
return hj_obj.full_join(right_input, std::nullopt, stream);
return hj_obj.full_join(right_input, stream);
};

BM_join<key_type, payload_type, Nullable>(state, join);
Expand Down