Skip to content

Add non-functional parameters in where for compatibility with dask #11344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: branch-22.12
Choose a base branch
from

Conversation

galipremsagar
Copy link
Contributor

Closes #10104

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Jul 25, 2022
@github-actions github-actions bot added CMake CMake build issue Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jul 25, 2022
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions github-actions bot removed libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Sep 24, 2022
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Base: 87.47% // Head: 88.20% // Increases project coverage by +0.72% 🎉

Coverage data is based on head (d937139) compared to base (f817d96).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d937139 differs from pull request most recent head 70d2e71. Consider uploading reports for the commit 70d2e71 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11344      +/-   ##
================================================
+ Coverage         87.47%   88.20%   +0.72%     
================================================
  Files               133      133              
  Lines             21826    24640    +2814     
================================================
+ Hits              19093    21733    +2640     
- Misses             2733     2907     +174     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 94.22% <100.00%> (+0.49%) ⬆️
python/cudf/cudf/core/frame.py 93.68% <100.00%> (ø)
python/cudf/cudf/core/series.py 96.07% <100.00%> (+0.33%) ⬆️
python/cudf/cudf/__init__.py 90.19% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/indexed_frame.py 91.99% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/core/udf/__init__.py 50.00% <0.00%> (ø)
python/cudf/cudf/core/udf/strings_lowering.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 88.55% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.22% <0.00%> (+0.21%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr
Copy link
Contributor

vyasr commented Nov 3, 2022

@galipremsagar is this important for us to get into the release?

@galipremsagar
Copy link
Contributor Author

galipremsagar commented Nov 3, 2022

@galipremsagar is this important for us to get into the release?

Not necessary but it's a trivial fix, I'll revive the PR today. It was previously waiting on 22.12 jobs to be active.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@galipremsagar galipremsagar changed the base branch from branch-22.10 to branch-22.12 November 3, 2022 20:32
@github-actions github-actions bot added CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. and removed Python Affects Python cuDF API. labels Nov 3, 2022
@github-actions github-actions bot added Python Affects Python cuDF API. and removed libcudf Affects libcudf (C++/CUDA) code. conda CMake CMake build issue labels Nov 3, 2022
@vyasr
Copy link
Contributor

vyasr commented Nov 4, 2022

rerun tests

@galipremsagar
Copy link
Contributor Author

Dask upstream seems to be doing an axis=1(column-wise) where call, which we don't yet have support for. I'll move this to next release for now, i'm thinking of a nicer solution on dask upstream, if it is in by burndown I'll re-tag to 22.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dask cuDF cummax and cummin fail due to missing axis argument in cuDF.Series.where
2 participants