-
Notifications
You must be signed in to change notification settings - Fork 941
Add non-functional parameters in where
for compatibility with dask
#11344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-22.12
Are you sure you want to change the base?
Conversation
This PR has been labeled |
Codecov ReportBase: 87.47% // Head: 88.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11344 +/- ##
================================================
+ Coverage 87.47% 88.20% +0.72%
================================================
Files 133 133
Lines 21826 24640 +2814
================================================
+ Hits 19093 21733 +2640
- Misses 2733 2907 +174
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@galipremsagar is this important for us to get into the release? |
Not necessary but it's a trivial fix, I'll revive the PR today. It was previously waiting on |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rerun tests |
Dask upstream seems to be doing an |
Closes #10104
Checklist