Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 #207

Merged
merged 14 commits into from
Mar 4, 2025
Merged

Add Python 3.13 #207

merged 14 commits into from
Mar 4, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 19, 2024

This PR adds Python 3.13 CI images for ci-wheel and citestwheel.

For now we are blocked by conda-forge/conda-feedstock#246 on adding Python 3.13 support to our conda CI images. However, I went ahead and did some refactoring that will be needed for conda support once that is available.

@bdice bdice marked this pull request as ready for review December 17, 2024 01:33
@bdice bdice requested a review from a team as a code owner December 17, 2024 01:33
@bdice bdice requested review from AyodeAwe and removed request for a team December 17, 2024 01:33
@jakirkham
Copy link
Member

This is now failing as boa requires an older version of conda, which is incompatible with Python 3.13

Sounds like we should prioritize dropping boa to move Python 3.13 forward: rapidsai/build-planning#149

@bdice
Copy link
Contributor Author

bdice commented Feb 21, 2025

I wrote up an automation script that we can use to convert all RAPIDS repositories from conda mambabuild to conda build, which would allow us to drop boa. However, we are also working through a migration to rattler-build which will effectively drop boa.

Even if we dropped boa, we would still be blocked from migrating to Python 3.13 because cupy doesn't support Python 3.13 yet. cupy/cupy#8651

In the interest of keeping our total work at a minimum: if cupy and other RAPIDS dependencies become available for Python 3.13 but still haven't finished the rattler-build upgrade, then we can migrate all remaining RAPIDS repositories off of boa to unblock the Python 3.13 upgrade.

jakirkham and others added 4 commits February 28, 2025 12:26
Upstream has archived `boa` and recommended moving to `rattler-build`.
So this drops `boa` from our images.

Also as `boa` does not support Python 3.13 (unmaintained), dropping
`boa` is a prerequisite to adding Python 3.13. There are other
dependencies it pins to old versions that will be able to get updates
too.

We tried dropping this before, but it caused issues with the RAPIDS
25.02 release. Once the RAPIDS 25.02 release is complete, let's give
this another try.
@bdice
Copy link
Contributor Author

bdice commented Mar 4, 2025

This should be unblocked now.

@jameslamb jameslamb requested review from jameslamb and removed request for AyodeAwe March 4, 2025 19:37
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checked a couple build logs, saw the things I expected... the right build-string filters to say "only give us CPython", the right Python versions installed, and no new warnings to worry about.

I'm ok with duplicating the PYTHON_*_VERSION logic in the Dockerfile instead of doing that in compute-build-args.sh, think that's fine.

@bdice bdice merged commit aeb539c into rapidsai:main Mar 4, 2025
686 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants