Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component name guessing #6

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Component name guessing #6

merged 2 commits into from
Oct 23, 2024

Conversation

royduin
Copy link
Member

@royduin royduin commented Oct 16, 2024 •
edited
Loading

Trying to use this new feature: laravel/framework#52669 but doesn't seem to work due incorrect guessing when there is a vendor prefix. With some dump()s:

"rapidez::input" // Illuminate/View/Compilers/ComponentTagCompiler.php:376
"rapidez::components.input.index" // Illuminate/View/Compilers/ComponentTagCompiler.php:382
"rapidez::components.input.rapidez::input" // Illuminate/View/Compilers/ComponentTagCompiler.php:388

@royduin royduin mentioned this pull request Oct 16, 2024
Merged
@royduin
Copy link
Member Author

royduin commented Oct 16, 2024

Fix: laravel/framework#53183

@royduin
Copy link
Member Author

royduin commented Oct 17, 2024

Let's wait for the release so we can bump the version constraint

@royduin royduin marked this pull request as ready for review October 23, 2024 11:10
@royduin royduin merged commit cc90f4f into master Oct 23, 2024
1 check passed
@royduin royduin deleted the component-name-guessing branch October 23, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@royduin