Refactor/Extract Common Credential Module #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shared_credential classes.
|
|
||
|
|
||
| # Credential type options. | ||
| module Type |
There was a problem hiding this comment.
We should check to see if there are any new ones to go into the constants here. (Yes, unfortunately, it's a manual process.)
There was a problem hiding this comment.
All synced up, no new ones to add.
| sc_creds_snmpv3authtype: @auth_type, | ||
| sc_creds_snmpv3privtype: @privacy_type, | ||
| sc_creds_snmpv3privpassword: @privacy_password, | ||
| siteid: -1 } |
There was a problem hiding this comment.
This field doesn't matter, right? Technically we could have a site ID for site credentials, but I don't think it would get used, unless for logging.
…to ElevationType, changed test method signature to accept siteid.
mdaines-r7
added a commit
that referenced
this pull request
Dec 29, 2014
Refactor/Extract Common Credential Module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
CredentialtoSiteCredential.Created a new super class
Credentialto hold the testing method(s), the constants and common modules.This allowed both
SiteCredential, andSharedCredentialto have access to the testing method to test newly created credentials.Reference Issue: #96
@mdaines-r7 @asalazar-r7 @gschneider-r7
Main changes made are for the signature
_to_param(target, engine_id, port)and setting the@portinside thetestmethod.Everything else should be exactly the same