Update Global Settings

[erran]

@mdaines-r7 (@defndaines) Can you check this PR out? I'd like to get it merged for some automated tests I'm working on right now.

[erran-r7]

# Before updating the Nexpose gem
When(/^I (disable|enable) the global setting for Controls Scanning$/) do |action|
  state_for_action =
    case action
    when 'disable' then '0'
    when 'enable' then '1'
    end

  global_settings_response = Nexpose::AJAX.get(@nexpose_client, '/data/admin/global-settings')
  global_settings = REXML::Document.new(global_settings_response)

  controls_scan = REXML::XPath.first(global_settings, 'GlobalSettings/ControlsScan')
  enable_controls_scan = REXML::XPath.first(controls_scan, 'enableControlsScan')

  enable_controls_scan.add_attribute('enabled', state_for_action)
  # This would fail for some reason.
  Nexpose::AJAX.post(@nexpose_client, '/data/admin/global-settings', global_settings)
end

# After (without #87)
When(/^I (disable|enable) the global setting for Controls Scanning$/) do |action|
  global_settings = Nexpose::GlobalSettings.load(@nexpose_client)

  case action
  when 'disable'
    global_settings._set_controls_scanning(global_settings.xml, false)
  when 'enable'
    global_settings._set_controls_scanning(global_settings.xml, true)
  end

  global_settings.save(@nexpose_client)
end

# After (with #87)
When(/^I (disable|enable) the global setting for Controls Scanning$/) do |action|
  global_settings = @nexpose_client.global_settings

  case action
  when 'disable'
    global_settings.controls_scanning = false
  when 'enable'
    global_settings.controls_scanning = true
  end

  global_settings.save(@nexpose_client)
end

cc: @nbibinagar-r7

[mdaines-r7]

Why change all the names? There a fairly strong convention across the gem to use the underscore to indicate the private methods that are meant for internal utility.

Also, I've had some problems using private methods in the gem. I cannot remember what the problems were, but it's one of the reasons for adding the naming conventions.

[erran-r7]

I've seen similar naming conventions in JS. I knew what was being done but since Ruby provides privacy levels I opt'd to remove the unneeded convention in this particular case.

[mbuck-r7]

Just saw this comment come through, so I'll pile on. :) In Ruby, you rarely see folks using the prepended underscore to indicate private methods, since you can enforce method hiding with the private keyword. You are forbidden from calling private methods outside of the class in which they are declared, which could be the cause of the issues you're seeing.

[erran-r7]

@mdaines-r7 I've removed Nexpose::Connection#global_settings