Validate and raise error for unsupported colors #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to hold off on merging until I can confirm that this doesn't conflict with internal testing. |
| # Set the color but validate it | ||
| def color=(hex) | ||
| unless Type::Color::VALID_COLORS.include?(hex.to_s.downcase) | ||
| raise ArgumentError, "Unable to set color to an invalid color.\nUse one of #{Type::Color::VALID_COLORS}" |
There was a problem hiding this comment.
We've been using a style like Type::Color.constants internally to do similar things. Allows you to avoid storing it as a separate value, and if a new constant is added, it gets picked up automatically.
There was a problem hiding this comment.
Sounds good. 👍 I'm used to doing the same, but wasn't sure how it's handled in here.
@mdaines-r7 Understood. Fine by me. |
mdaines-r7
added a commit
that referenced
this pull request
Jun 6, 2014
Validate and raise error for unsupported colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Nexpose::Tagto respect Nexpose's allowed tag color values.