Make HostOrIP#convert more flexible on IP address range input #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context 'with an IP address range with whitespace' do | ||
| let(:asset) { asset = '192.168.1.0 - 192.168.1.255' } | ||
|
|
||
|
|
|
Oh I just realized this won't work with hyphenated hostnames... now I remember why it had whitespace. |
|
Actually nevermind, there is a test that proves my last comment wrong. 😵 |
| @@ -50,7 +50,7 @@ module HostOrIP | |||
| # @return [IPRange|HostName] Valid class, if it can be converted. | |||
| # | |||
| def convert(asset) | |||
| ips = asset.split(' - ') | |||
| ips = asset.split('-').map(&:strip) | |||
There was a problem hiding this comment.
do we need to add a nil check here?
There was a problem hiding this comment.
I guess we could just to throw a different error. I think this can only fail if the asset input is nil, which is true today anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had discussions with 2 different people today where this change would be very useful to them, so figured I'd throw it in here so they don't have to do it in their own scripts.
As you can see in the new tests, IP ranges are now converted with or without whitespace. As long as there is a hyphen (
-) it should correctly make a range regardless of whitespace.