Add methods for changing and querying a scan template's ACES logging level #187
Conversation
| return 'default' if logging.nil? | ||
| aces = REXML::XPath.first(logging, 'aces') | ||
| return 'default' if aces.nil? | ||
| return aces.attributes['level'] |
There was a problem hiding this comment.
Minor, but this could return nil here if aces_level= is called with nil. Perhaps only valid values should be allowed as args to aces_level and/or an attribute existence test is in order here.
There was a problem hiding this comment.
Would agree with Jon, might enter into some weirdness if the aces.attributes level value is nil.
There was a problem hiding this comment.
Added sanity checking.
|
Since this is for product functionality that is not yet released, what is the impact of using it against a product version that does not have this functionality. IOW, if someone tries to modify a pre-ACES product's scan template to use ACES, what happens? Does the scan template still work, are there side effects, etc? |
|
@jhart-r7 The scan template is just XML, and Nexpose doesn't validate what XML you send it. Any XML that Nexpose doesn't know to check for will be ignored. |
|
That said I would rather this go out on the first gem update post SixO. |
Add methods for changing and querying a scan template's ACES logging level
No description provided.