Fixed silo profile creation #185
Conversation
Updated the error message to check for update vs create condition.
| @@ -107,7 +107,7 @@ def save(connection) | |||
| begin | |||
| update(connection) | |||
| rescue APIError => error | |||
| raise error unless (error.message =~ /A silo profile .* does not exist./) | |||
| raise error unless (error.message =~ /The silo profile .* does not exist/) | |||
There was a problem hiding this comment.
So #160's root cause is that the message for the error changed ever so slightly, and your fix is to ... change it here ever so slightly. Why not:
raise error unless (error.message =~ /\S+ silo profile .* does not exist/
or something similarly more flexible?
(Also, OT, but Ideally there'd be a dedicated exception class for this so you could check the type rather than the message, but this is not an uncommon pattern, especially since the Nexpose gem is somewhat at the mercy of what Nexpose itself responds with)
There was a problem hiding this comment.
Some day we'll have a fully RESTful JSON API to replace this that returns appropriate status codes instead of messages that must be parsed. 😃
I am not too concerned about flexibility since this message really shouldn't change again (or if it does the above should come true first).
There was a problem hiding this comment.
I would agree with @jhart-r7 - might as well just not worry about it again until we have to change it to handle status codes.
| @@ -107,7 +107,7 @@ def save(connection) | |||
| begin | |||
| update(connection) | |||
| rescue APIError => error | |||
| raise error unless (error.message =~ /A silo profile .* does not exist./) | |||
| raise error unless (error.message =~ /\S+ silo profile .* does not exist/) | |||
There was a problem hiding this comment.
this might work better.
/silo profile(\S*|.*?)does not exist/i
Should match all of these, according to http://rubular.com/
aSa silo profile does not exist
silo profile does not exist
A silo profile #1223-a does not exist
A silo profile 123 does not exist
silo profile abcd does not exist
A Silo Profile Does Not Exist
Fixed silo profile creation
Updated the error message to check for update vs create condition. Resolves #160