Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, enhance and fix bugs in ScanTemplate #183

Merged
merged 9 commits into from
Sep 29, 2015
Merged

Refactor, enhance and fix bugs in ScanTemplate #183

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
21cf20e
Fix NoMethodError when ScanTemplate has no explicitly enabled checks
jhart-r7 Aug 21, 2015
a3198cd
Add unit test for NME in ScanTemplate
jhart-r7 Aug 21, 2015
1f80f56
Allow checks to be enabled in a template if none had been before
jhart-r7 Aug 22, 2015
1515c9e
Allow checks types/categories to be enabled in a template if none had…
jhart-r7 Aug 22, 2015
e945ea3
Add spec for scan template
jhart-r7 Aug 22, 2015
1712944
Refactor check/type/category-based enabling/disabling in templates; test
jhart-r7 Aug 22, 2015
b3a2b45
Bump to 3.0.0 given method name/signature changes
jhart-r7 Aug 24, 2015
2333038
Revert "Bump to 3.0.0 given method name/signature changes"
jhart-r7 Aug 26, 2015
c88b0e9
Alias and test old methods. These can be removed w/ 3.0
jhart-r7 Aug 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow checks types/categories to be enabled in a template if none had… 
… been before
  • Loading branch information
@jhart-r7
jhart-r7 committed Aug 22, 2015
commit 1515c9efb28e326a2690097392851c72e6d1ea06
3 changes: 2 additions & 1 deletion lib/nexpose/scan_template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,8 @@ def remove_checks_by_type(type)
def _enable_check(check, elem)
checks = REXML::XPath.first(@xml, '//VulnerabilityChecks')
checks.elements.delete("Disabled/#{elem}[@name='#{check}']")
checks.elements['Enabled'].add_element(elem, { 'name' => check })
enabled_checks = checks.elements['Enabled'] || checks.add_element('Enabled')
enabled_checks.add_element(elem, { 'name' => check })
end

def _disable_check(check, elem)
Expand Down