Blackouts #170
Merged
Blackouts #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| repeat_hash= { | ||
| type: @blackout_type, | ||
| interval: @blackout_interval } |
There was a problem hiding this comment.
Please use consistent formatting on the hashes, lining up the brackets etc.
| attr_accessor :blackout | ||
|
|
||
| def initialize(blackout) | ||
| @global_blackout = Array(blackout) |
There was a problem hiding this comment.
should this just be @blackout or do we need to add an attr_ for global_blackout as well?
I might just be missing something due to a case of the Mondays.
There was a problem hiding this comment.
I think it should be something else. We have a GlobalBlackout object what does a blackout of a GlobalBlackout mean? is it the schedule of a GlobalBlackout? if so then it should be called schedule. That way it's GlobalBlackout.schedule as oppose to GlobalBlackout.blackout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silo and site level blackout Gem changes